Repository navigation
fix(google-auth): fix TYPE_CHECKING imports in _default.py - #19078
Open
sakshamgoyal-01 wants to merge 1 commit into
Open
sakshamgoyal-01 wants to merge 1 commit into
sakshamgoyal-01 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the type checking imports in packages/google-auth/google/auth/_default.py to import the google.auth.credentials and google.auth.transport modules directly, rather than importing specific classes with type-ignore comments. There are no review comments, so I have no additional feedback to provide.
sakshamgoyal-01
marked this pull request as ready for review
November 13, 2026 20:49
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19077
(Note: This is an AI-generated PR.)
Import
google.auth.credentialsandgoogle.auth.transportmodules instead of theCredentialsandRequestclasses ingoogle/auth/_default.py'sTYPE_CHECKINGblock so type checkers (e.g., Pyright / BasedPyright) can resolvegoogle.auth.default()'s parameter and return types instead of treating them asUnknown.