Incorrect check for Windows (case sensitivity) #953

Activity

1. brianfromoregon commented on Jan 21, 2020

   

   brianfromoregon

   on Jan 21, 2020

   Author

   More actions

   If I change it locally to be case insensitive, I see this (again on win10)

   
   java.nio.file.attribute.UserPrincipalNotFoundException: null
   	at sun.nio.fs.WindowsUserPrincipals.lookup(WindowsUserPrincipals.java:147) ~[?:?]
   	at sun.nio.fs.WindowsFileSystem$LookupService$1.lookupPrincipalByName(WindowsFileSystem.java:244) ~[?:?]
   	at com.google.api.client.util.store.FileDataStoreFactory.setPermissionsToOwnerOnlyWindows(FileDataStoreFactory.java:158) ~[main/:1.32.1]
   	at com.google.api.client.util.store.FileDataStoreFactory.<init>(FileDataStoreFactory.java:71) ~[main/:1.32.1]
   
   
2. yoshi-automation

   added

   triage meI really want to be triaged.I really want to be triaged.

   🚨This issue needs some love.This issue needs some love.

   on Jan 22, 2020
3. chingor13

   added

   priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.

   type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

   on Jan 27, 2020
4. yoshi-automation

   removed

   🚨This issue needs some love.This issue needs some love.

   triage meI really want to be triaged.I really want to be triaged.

   on Jan 27, 2020
5. MartijnWoudstra commented on Mar 24, 2020

   

   MartijnWoudstra

   on Mar 24, 2020

   More actions

   Furthermore, the .lookupPrincipalByName("OWNER@"); seems to be throwing the UserPrincipalNotFoundException
6. elharo

   closed this as completedin #927on Mar 25, 2020
7. JustinBeckwith

   assigned

   elharo

   on Feb 2, 2021
8. clundin25

   added a commit that references this issue on Aug 11, 2022

   ci: adjust owlbot-java for monorepo (googleapis#1500) (googleapis#953)

   ...

   669ed24