This repository was archived by the owner on Aug 13, 2026. It is now read-only.
Repository navigation
samples: update synth.py to exclude samples.yaml - #536
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
=========================================
Coverage 78.79% 78.79%
Complexity 376 376
=========================================
Files 27 27
Lines 3414 3414
Branches 171 171
=========================================
Hits 2690 2690
Misses 651 651
Partials 73 73 Continue to review full report at Codecov.
|
chingor13
approved these changes
Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to prevent synth from proposing PRs like #533. The synth-proposed change will cause the samples checkstyle test to miss this file https://github.com/googleapis/java-pubsub/blob/master/samples/checkstyle-suppressions.xml and therefore fail the checkstyle test.
The checkstyle exclusions are for classes generated by Avro tools and protoc. They don't comply to the strict checkstyle rules.