Enable self-signed JWT flow for v1beta2 #174

Activity

1. busunkim96

   added

   type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

   priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.

   on Jul 8, 2021
2. product-auto-label

   added

   api: documentaiIssues related to the googleapis/python-documentai API.Issues related to the googleapis/python-documentai API.

   on Jul 8, 2021
3. busunkim96

   changed the title [-]Enable self-signed JWT flow[/-] [+]Enable self-signed JWT flow for v1beta2[/+] on Jul 8, 2021
4. telpirion

   assigned

   busunkim96

   on Jul 22, 2021
5. telpirion

   added

   type: processA process-related concern. May include testing, release, or the like.A process-related concern. May include testing, release, or the like.

   and removed

   type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

   on Aug 5, 2021
6. telpirion

   assigned

   nicain

   on Aug 5, 2021
7. busunkim96 commented on Aug 9, 2021

   

   busunkim96

   on Aug 9, 2021

   ContributorAuthor

   More actions

   For more context, see this doc(specifically "Handling of Regional Endpoints as the default host")

   documentai used to listus-documentai.googleapis.com as the default endpoint for all of its versions. self-signed JWT needs to always use the global endpoint as the audience.

   The default endpoint was changed to documentai.googleapis.com in this commit for documentai v1 and documentai v1beta3. An update to the documentai v1beta2 protos will allow the customizations in owlbot.py to also be removed.

   python-documentai/owlbot.py

   Lines 39 to 60 in e1e8fce

   	s.replace(library / "google/cloud/documentai_v1beta2/**/base.py",
   	"""scopes_kwargs = \{"scopes": scopes, "default_scopes": cls\.AUTH_SCOPES\}""",
   	"""# Documentai uses a regional host (us-documentai.googleapis.com) as the default
   	# so self-signed JWT cannot be used.
   	# Intentionally pass default scopes as user scopes so the auth library
   	# does not use the self-signed JWT flow.
   	# https://github.com/googleapis/python-documentai/issues/174
   	scopes_kwargs = {"scopes": scopes or cls.AUTH_SCOPES, "default_scopes": cls.AUTH_SCOPES}""")
   	s.replace(library / "tests/**/documentai_v1beta2/*.py",
   	"""(@requires_google_auth_gte_1_25_0
   	def test_document_.*?_service_base_transport_with_credentials_file.*?)scopes=None,""",
   	"""\g<1>scopes=("https://www.googleapis.com/auth/cloud-platform",),""",
   	flags=re.MULTILINE | re.DOTALL,
   	)
   	s.replace(library / "tests/**/documentai_v1beta2/*.py",
   	"""(@requires_google_auth_gte_1_25_0
   	def test_document_.*?_service_auth_adc.*?)scopes=None,""",
   	"""\g<1>scopes=("https://www.googleapis.com/auth/cloud-platform",),""",
   	flags=re.MULTILINE | re.DOTALL,
   	)
8. nicain

   added

   owlbot:runAdd this label to trigger the Owlbot post processor.Add this label to trigger the Owlbot post processor.

   and removed

   owlbot:runAdd this label to trigger the Owlbot post processor.Add this label to trigger the Owlbot post processor.

   on Aug 10, 2021
9. parthea

   closed this as completedin #191on Sep 1, 2021