Skip to content
This repository was archived by the owner on Oct 13, 2026. It is now read-only.
This repository was archived by the owner on Oct 13, 2026. It is now read-only.

PublisherClient methods no longer supporting previous way of calling #194

Closed

Description

@sli2126

It looks like methods no longer take topic name/path as an unnamed arg, causing test failures in Python Logging and Storage clients:
https://source.cloud.google.com/results/invocations/a5ade010-9ee5-463b-ad2e-6e106badb197/targets
https://source.cloud.google.com/results/invocations/44fbcc26-bb84-421d-bbca-fee58f6df1c2/targets

Steps to reproduce

  1. Run tests/system/test_system.py in python-logging or python-storage.

Code example

publisher = pubsub_v1.PublisherClient()
publisher.create_topic(topic_path)

Stack trace

.nox/system-3-6/lib/python3.6/site-packages/google/cloud/pubsub_v1/_gapic.py:40: in <lambda>
    fx = lambda self, *a, **kw: wrapped_fx(self.api, *a, **kw)  # noqa
.nox/system-3-6/lib/python3.6/site-packages/google/pubsub_v1/services/publisher/client.py:310: in create_topic
    request = pubsub.Topic(request)

Activity

  1. added
    type: questionRequest for information or clarification. Not an issue.
    on Sep 16, 2020
  2. plamut commented on Sep 16, 2020

    @plamut
    Contributor

    @sli2126 I presume you are talking about the new major version released a few days ago, i.e. 2.0.0?

    Your observation is correct, as the major version introduced several breaking changes, dropped Python 2.7 and 3.5 support, etc. - the UPGRADING guide explains the differences.

    As for the failing tests, the libraries should pin the PubSub dependency to <2.0.0dev until the code is adjusted.

    Edit: I see there is already a PR for that in python-storage.

  3. sli2126 commented on Sep 16, 2020

    @sli2126
    Author

    Understood, thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.type: questionRequest for information or clarification. Not an issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions