Skip to content
This repository was archived by the owner on Oct 13, 2026. It is now read-only.

chore: add psutil to synth.py - #55

Merged
pradn merged 3 commits into
masterfrom
fix-gapic-synth
Mar 23, 2020
Merged

pradn merged 3 commits into
masterfrom
fix-gapic-synth

Conversation

@hongalex

Copy link
Copy Markdown
Member

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2020
@hongalex
hongalex requested a review from pradn March 23, 2020 21:16
@hongalex hongalex changed the title add psutil to synth.py chore: add psutil to synth.py Mar 23, 2020
@pradn
pradn merged commit 6242018 into master Mar 23, 2020
@pradn
pradn deleted the fix-gapic-synth branch March 23, 2020 21:58
@plamut

plamut commented Mar 24, 2020

Copy link
Copy Markdown
Contributor

Process question - should we also regenerate the files every time when synth.py is updated, and commit those changes, too?

@busunkim96

Copy link
Copy Markdown
Contributor

@plamut Generally yes, but I think in this case the dependency was already in noxfile.py.

@plamut

plamut commented Mar 24, 2020

Copy link
Copy Markdown
Contributor

That's true, its not strictly necessary to manually regenerate now, can wait until the next autosynth.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants