Repository navigation
feat(all): Add new GraphQL scalar type Int8 - #4511
Merged
Merged
Conversation
dotansimha
force-pushed
the
int8-scalar
branch
2 times, most recently
from
April 3, 2023 15:48
f41e83a to
7000fc3
Compare
dotansimha
force-pushed
the
int8-scalar
branch
7 times, most recently
from
April 17, 2023 09:28
3ccd62a to
87e1dca
Compare
dotansimha
marked this pull request as ready for review
April 17, 2023 09:37
dotansimha
force-pushed
the
int8-scalar
branch
2 times, most recently
from
April 17, 2023 11:28
865a9bc to
b0bb9fa
Compare
Int8Int8 (rust: i64, pg: bigint)
lutter
approved these changes
Apr 17, 2023
dotansimha
force-pushed
the
int8-scalar
branch
6 times, most recently
from
May 31, 2023 11:29
4af3fc0 to
cf25a15
Compare
lutter
approved these changes
Jun 1, 2023
lutter
left a comment
Contributor
There was a problem hiding this comment.
This looks great!
Just change the unwrap before committing. Also, for the commit message, something like
all: Add new scalar type Int8
would be more in line with what we've been doing
But with these two touchups, this is good to merge.
Int8 (rust: i64, pg: bigint)Int8
Contributor
Author
|
Thanks @lutter . Fixed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
storestoregraph-ts(Added support for handling Int8 scalar as i64 graph-tooling#1296)