Repository navigation
Improve ABI file path validation - #1766
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 7bf1706 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Error message now shows within CLI interactive session instead of error crash - Passing `--abi` will correctly pre-fill the interactive form - Catch JSON parsing exception for `EthereumABI`. Closes: graphprotocol#1765
0237h
force-pushed
the
fix/abi-file-verification
branch
from
November 11, 2024 17:16
60b4323 to
7bf1706
Compare
YaroShkvorets
approved these changes
Nov 12, 2024
YaroShkvorets
left a comment
Contributor
There was a problem hiding this comment.
LGTM
works with SPKG files too
This was referenced Nov 27, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--abiwill correctly pre-fill the interactive formEthereumABI.Closes: #1765