Repository navigation
Conversation
|
|
HealthCheckingLoadBalancerFactory created the Health.Watch call with whatever Context was current on the thread that drained the SynchronizationContext. That thread can be serving an unrelated RPC, so the end of that RPC cancelled the health-check stream. The immediate restart ran in the cancelled Context too and failed before any response, which put every such subchannel into TRANSIENT_FAILURE until the backoff expired. Create the call under Context.ROOT, as GrpcXdsTransportFactory does for the xDS stream.
Martozar
force-pushed
the
health-check-root-context
branch
from
November 10, 2026 10:25
9889b3f to
f8199a0
Compare
Author
|
/easycla |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HealthCheckingLoadBalancerFactory created the Health.Watch call with whatever Context was current on the thread that drained the SynchronizationContext. That thread can be serving an unrelated RPC, so the end of that RPC cancelled the health-check stream. The immediate restart ran in the cancelled Context too and failed before any response, which put every such subchannel into TRANSIENT_FAILURE until the backoff expired.
Create the call under Context.ROOT, as GrpcXdsTransportFactory does for the xDS stream.