Repository navigation
servlet: Avoid sending Trailers-Only responses - #13186
Open
kannanjgithub wants to merge 1 commit into
Open
kannanjgithub wants to merge 1 commit into
kannanjgithub wants to merge 1 commit into
Conversation
Tomcat does not set END_STREAM on a Trailers-Only HEADERS frame; it terminates the stream with an empty DATA frame instead, which the client rejects as "Received unexpected EOS on empty DATA frame from server", discarding the real status. Always send headers followed by trailers. This fixes flaky TomcatInteropTest failures and re-enables the Tomcat interop and transport tests that were ignored for lack of trailers-only support. Since servlet servers now deliver their own status when the server-side deadline fires first (rather than resetting the stream), AbstractInteropTest.deadlineExceeded also accepts the server's "context timed out" description. AbstractTransportTest's earlyServerClose_noServerHeaders now accepts comma-joined duplicate ASCII trailer values, as basicStream already does, since servlet trailers are set via a Map<String, String>. TAG=agy CONV=367f1e32-a85a-4e2f-99f3-3ac0e3d14e20
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tomcat does not set END_STREAM on a Trailers-Only HEADERS frame; it terminates the stream with an empty DATA frame instead, which the client rejects as "Received unexpected EOS on empty DATA frame from server", discarding the real status. Always send headers followed by trailers. This fixes flaky TomcatInteropTest failures and re-enables the Tomcat interop and transport tests that were ignored for lack of trailers-only support.
Since servlet servers now deliver their own status when the server-side deadline fires first (rather than resetting the stream),
AbstractInteropTest.deadlineExceededalso accepts the server's "context timed out" description.AbstractTransportTest's earlyServerClose_noServerHeadersnow accepts comma-joined duplicate ASCII trailer values, as basicStream already does, since servlet trailers are set via a Map<String, String>.