Repository navigation
tests: suppress data_too_large in all fuzz tests that draw in a loop - #380
Open
pylaterreur wants to merge 1 commit into
Open
pylaterreur wants to merge 1 commit into
pylaterreur wants to merge 1 commit into
Conversation
The fuzz tests that draw read, write or chunk sizes from data() until their input is consumed overrun Hypothesis's buffer on large inputs, and the data_too_large health check fails them depending on the seed. This was patched for one test at a time (e98b641, 3ea96b6). In the last 60 scheduled runs of test.yml on main, it failed TestCompressor_compressobj_fuzzing::test_flush_block (ubuntu-24.04-arm, 3.14, 2026-11-08) and ::test_random_input_sizes (macos-26, 3.12, 2026-10-31; windows-11-arm, 2026-11-04), and on a fork run TestCompressor_chunker_fuzzing::test_flush_block. Suppress it in the 21 such tests that did not yet. With the seeds of the 2026-11-08 and 2026-10-31 runs, the two compressobj tests fail the health check locally before this change and pass after it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GwUvhmzgfkiZ6vo4uGyesN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fuzz tests that draw read, write or chunk sizes from
data()until their input is consumed can overrun Hypothesis's buffer when they sample a large input, and thedata_too_largehealth check then fails them depending on the seed:This was suppressed for one test at a time when it tripped (e98b641, 3ea96b6). In the last 60 scheduled runs of test.yml on
mainit failed:TestCompressor_compressobj_fuzzing::test_flush_block: ubuntu-24.04-arm, 3.14, C backend (2026-11-08);TestCompressor_compressobj_fuzzing::test_random_input_sizes: macos-26, 3.12, CFFI backend (2026-10-31), and windows-11-arm, CFFI backend (2026-11-04);TestCompressor_chunker_fuzzing::test_flush_block(windows-2022, 3.12, x86).This suppresses it in the 21 such tests that did not suppress it yet.
test_read_across_frames_falsehad no settings, so it gets asuppress_health_checklist with just this check.With the seeds those CI runs printed, both
compressobjtests fail the health check locally onmain(Linux, 3.12,HYPOTHESIS_PROFILE=ci,ZSTD_SLOW_TESTS=1) and pass with this change:tests/test_compressor_fuzzing.pyandtests/test_decompressor_fuzzing.pypass with theciprofile: 41 tests with the C backend, 39 passed and 2 skipped with the CFFI backend.ruff checkpasses andruff formatleaves the files unchanged.Prepared with the help of Claude Code.
🤖 Generated with Claude Code
https://claude.ai/code/session_01GwUvhmzgfkiZ6vo4uGyesN