Repository navigation
Read a log error's message from where "error:" matched, not the first "error" in the line [patch] - #416
Open
matt-edmondson wants to merge 1 commit into
Open
Read a log error's message from where "error:" matched, not the first "error" in the line [patch]#416matt-edmondson wants to merge 1 commit into
matt-edmondson wants to merge 1 commit into
Conversation
…he first "error" in the line ParseLogForErrors cut a compiler-style line at the first colon after the first "error" anywhere in it, so a path like src/errors.c or a repository named error-codes left a "line:col: error:" prefix on the message, and the same error at two locations was reported twice. The message now starts right after the ErrorPatternRegex match. Fixes #415 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW3WKKpY45VJvchCp92
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #415
What changed
GitHub.ParseLogForErrorsfound error lines withErrorPatternRegex(), but it took the message from the first colon after the firsterroranywhere in the line. If a path contained "error" (src/errors.c, a repo namederror-codes), the Errors column showed12:5: error: 'x' undeclaredinstead of'x' undeclared. It also counted the same compiler error at two locations as two different errors.ParseLogForErrorsis nowinternalso the test project can call it. The test project already sees internals throughInternalsVisibleTo.Tests
GitHubLogErrorsTestscovers:##[error]annotations and plain leadingError:lines, which behave as beforeinternalchange kept), 3 of the 5 tests fail, the same 3 the issue describes. With the fix, all pass.Generated by Claude Code