Repository navigation
Render a body of only blank lines as an empty block - #133
Merged
Merged
Conversation
WriteBody counted blank lines when choosing between an empty block, an expression body and a braced block, so a factory that only wrote a NewLine left the declaration with no body (CS0501). Blank lines are now ignored when choosing the shape; interior blank lines in a braced body are still spliced as written. Fixes #119 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01634kz4hrbkEJcGHKJWQjtA
|
This was referenced Oct 7, 2026
This was referenced Nov 2, 2026
matt-edmondson
added a commit
that referenced
this pull request
Nov 11, 2026
WriteBody left blank lines out only when deciding a body's shape, then spliced the factory's whole output. A factory that ended with NewLine() (the pattern #133 had in mind) added a second blank line between members, and one that started with NewLine() put a blank line between the signature and its opening brace. Leading and trailing blank lines are now trimmed before the body is spliced, for braced and comment-only bodies alike; blank lines inside the body are kept. Fixes #180 Claude-Session: https://claude.ai/code/session_017vfJW3rHMVCnBN5uuK5G3N Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119
What changed
TemplateRendering.WriteBodychooses between an empty block, an expression body and a braced block by counting lines, and it counted blank lines too. A factory that wrote only aNewLine()therefore producedpublic void M()with no body (CS0501). This hits methods, constructors and operators.WriteBodynow chooses the shape from the lines that have content:{ }.Tests
ABodyThatWritesOnlyBlankLinesRendersAsAnEmptyBlockcovers a method body with one and with twoNewLine()calls.AConstructorBodyThatWritesOnlyBlankLinesIsAnEmptyBlockcovers the same for a constructor.AnExpressionBodyBetweenBlankLinesStaysOnTheDeclarationLine.ABlankLineInsideABracedBodyIsKept, which pins the unchanged interior-blank behaviour.🤖 Generated with Claude Code
https://claude.ai/code/session_01634kz4hrbkEJcGHKJWQjtA
Generated by Claude Code