Repository navigation
Write a null quoted DefaultValue as "" instead of throwing [patch] - #210
Open
matt-edmondson wants to merge 1 commit into
Open
matt-edmondson wants to merge 1 commit into
matt-edmondson wants to merge 1 commit into
Conversation
With DefaultValueIsQuoted set, HasDefaultValue is true whatever the value, so a null DefaultValue reached QuoteStringLiteral and threw NullReferenceException after the declaration was partly written, leaving 'void M}'. A null is now read as empty, which DefaultValue's docs already say writes "". Fixes #209 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW2P5xiJJTm9Z4wJwcH
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
DefaultValueIsQuotedset,HasDefaultValueis true whatever the value. A nullDefaultValuetherefore reachedTemplateRendering.QuoteStringLiteraland threw aNullReferenceExceptionafter the declaration had been partly written, leavingvoid M}.WriteDefaultValueTonow reads a null quoted value as empty, so it writes= "", asDefaultValue's docs already say an empty quoted value does. The doc comment now mentions null too.Tests
DefaultValue = null!, DefaultValueIsQuoted = true. All four fail onmainwith the NRE and pass with the fix.Fixes #209
Generated by Claude Code