Repository navigation
Ensure that _geoslib is built with MSVC 14.0 for Windows Python3 - #565
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the hotfix release 1.3.6 of
basemap, this problem was first addressed, and after that it was possible to buildgeos_c.dllwith MSVC 14.0 for Python 3 on Windows. However, the_geoslibmodule was still being built with MSVC 19.33 because of some limitation in the GitHub Action used to setup MSVC. Furthermore, the solution in 1.3.6 is not enough in case we are trying to build GEOS >= 3.6 using theGeosLibraryhelper class.This PR addresses these remaining problems and ensures that the GitHub workflows build binaries linked with MSVC 14.0 for Python 3 on Windows.