Branch protection and merge rules? #119

Activity

1. jklymak commented on Nov 7, 2022

   

   jklymak

   on Nov 7, 2022

   Member

   More actions

   I think our policy has been @rougier merges. It he can relinquish that if he likes, in which case I think one review is ok unless a re-architecture.
2. rougier commented on Nov 28, 2022

   

   rougier

   on Nov 28, 2022

   Member

   More actions

   I'm not familiar with branch protection so I cannot really answer. Note that I'm late on GitHub notifications so do not wait for my review if too late (or you can mail me if really urgent)

   👍React with 👍1Reacted by hannah
3. story645 commented on Nov 28, 2022

   

   story645

   on Nov 28, 2022

   MemberAuthor

   More actions

   Branch protection means that GitHub will disallow pushing directly to main (well technically whichever branch you want) & won't let folks edit directly on main. https://github.com/proxy/docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/about-protected-branches
4. rougier commented on Nov 28, 2022

   

   rougier

   on Nov 28, 2022

   Member

   More actions

   Thanks for the explanation. Not strong opinion on that, I'll follow your advice and expertise.