Repository navigation
edenfs: enable OSS macOS build and startup - #1479
maxlepikhin wants to merge 6 commits into
Conversation
|
This pull request has been imported. If you are a Meta employee, you can view this in D127498188. (Because this pull request was imported automatically, there will not be any future comments.) |
|
Hi @maxlepikhin - thanks for the PR. I have a stack that I'm working on that should get EdenFS buildable and runnable with cmake. It's about halfway done, I'll try to get that landed ASAP and then will take a look at this PR. Even after I land my stack, I think your PR will still have changes to merge and land that my stack doesn't cover. For example, I built on macOS 26 and I see you have a macOS 27 fix. |
The changes in this PR make it buildable and runnable on MacOS 26, it worked for me. |
700adcf to
be8d797
Compare
|
@maxlepikhin has updated the pull request. You must reimport the pull request before landing. |
Summary
edenfsctlwith its Folly and Thrift runtime whenEDEN_USE_THRIFT_PYTHON_CLI=ON. The targeted build usesEDEN_BUILD_INTEGRATION_TESTS=OFF.pipe2in Eden common on macOS, where a binary built with the macOS 27 SDK can crash at startup on macOS 26.Addresses #1478.
Test Plan
mainupdate. The daemon, privileged helper, and packaged Python client built; the client started, an EdenFS NFS checkout mounted, and Bazel//:hellopassed in that checkout.main, getdeps dependency resolution,cargo metadata --lockedforeden/scm, andrustfmt --checkfor the changed Rust source passed. The external Eden common, Folly, and fbthrift patches apply to the updated pinned revisions.