Skip to content

edenfs: enable OSS macOS build and startup - #1479

Open
maxlepikhin wants to merge 6 commits into
meta:mainfrom
maxlepikhin:issue-1478-macos-edenfs
Open

maxlepikhin wants to merge 6 commits into
meta:mainfrom
maxlepikhin:issue-1478-macos-edenfs

Conversation

@maxlepikhin

@maxlepikhin maxlepikhin commented Oct 26, 2026 •

Copy link
Copy Markdown

Summary

  • Repair the OSS EdenFS build graph and Rust/C++ backingstore bridge so the daemon and privileged helper can be built on macOS arm64 with getdeps-managed dependencies.
  • Build and package the modern Python edenfsctl with its Folly and Thrift runtime when EDEN_USE_THRIFT_PYTHON_CLI=ON. The targeted build uses EDEN_BUILD_INTEGRATION_TESTS=OFF.
  • Avoid selecting pipe2 in Eden common on macOS, where a binary built with the macOS 27 SDK can crash at startup on macOS 26.

Addresses #1478.

Test Plan

  • A getdeps-managed source build completed on macOS arm64 with the dependency revisions pinned before the latest main update. The daemon, privileged helper, and packaged Python client built; the client started, an EdenFS NFS checkout mounted, and Bazel //:hello passed in that checkout.
  • On current main, getdeps dependency resolution, cargo metadata --locked for eden/scm, and rustfmt --check for the changed Rust source passed. The external Eden common, Folly, and fbthrift patches apply to the updated pinned revisions.
  • The full macOS build has not yet been rerun with the updated dependency revisions. Linux EdenFS has not been built locally.
  • A macOS EdenFS CI build would provide regression coverage; the repository does not currently run one for pull requests.

@meta-cla meta-cla Bot added the CLA Signed label Oct 26, 2026
@meta-codesync

meta-codesync Bot commented Oct 26, 2026

Copy link
Copy Markdown

This pull request has been imported. If you are a Meta employee, you can view this in D127498188. (Because this pull request was imported automatically, there will not be any future comments.)

@genevievehelsel

Copy link
Copy Markdown
Contributor

Hi @maxlepikhin - thanks for the PR. I have a stack that I'm working on that should get EdenFS buildable and runnable with cmake. It's about halfway done, I'll try to get that landed ASAP and then will take a look at this PR. Even after I land my stack, I think your PR will still have changes to merge and land that my stack doesn't cover. For example, I built on macOS 26 and I see you have a macOS 27 fix.

@maxlepikhin

Copy link
Copy Markdown
Author

Hi @maxlepikhin - thanks for the PR. I have a stack that I'm working on that should get EdenFS buildable and runnable with cmake. It's about halfway done, I'll try to get that landed ASAP and then will take a look at this PR. Even after I land my stack, I think your PR will still have changes to merge and land that my stack doesn't cover. For example, I built on macOS 26 and I see you have a macOS 27 fix.

The changes in this PR make it buildable and runnable on MacOS 26, it worked for me.

@maxlepikhin
maxlepikhin force-pushed the issue-1478-macos-edenfs branch from 700adcf to be8d797 Compare October 27, 2026 21:12
@facebook-github-tools

Copy link
Copy Markdown

@maxlepikhin has updated the pull request. You must reimport the pull request before landing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants