Repository navigation
Select existing environment before creating template project - #2012
Conversation
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
| : overrides.findIndex( | ||
| (s) => | ||
| !s.workspace && normalizePath(path.resolve(w.uri.fsPath, s.path)) === pwPath, | ||
| ); |
There was a problem hiding this comment.
Warning · Non-blocking recommendation
If a multi-root workspace folder is renamed, its existing setting retains the old workspace qualifier. Neither branch removes that entry, while project loading can still fall back to the matching path; removing the project then leaves it persisted and it reappears after reload. Please preserve the loader's orphaned-qualifier fallback here without removing an entry owned by another live root, and add a renamed-folder regression test.
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Users\rchiodo\AppData\Local\Programs\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "149662dcef3a50145fe0caa2c3435bec5e547d189f0e004515e3d751e32c381a": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found Test runs: none recorded. |
Rich Chiodo (rchiodo)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
4965e5e
754a672 to
4965e5e
Compare
Summary
Validation
npm run lintnpm run compile-testsnpm run unittest(3,546 passing, 9 pending)npm run compileFixes #518