Skip to content

Select existing environment before creating template project - #2012

Open
Stella Huang (StellaHuang95) wants to merge 1 commit into
microsoft:mainfrom
StellaHuang95:stellahuang-microsoft-issue-518-select-environment-for-project-created-w-b58ca2
Open

Stella Huang (StellaHuang95) wants to merge 1 commit into
microsoft:mainfrom
StellaHuang95:stellahuang-microsoft-issue-518-select-environment-for-project-created-w-b58ca2

Conversation

@StellaHuang95

Copy link
Copy Markdown
Contributor

Summary

  • select an existing environment before creating a template project when no new virtual environment is requested
  • keep cancellation free of filesystem, registration, and setting side effects
  • handle destination and registration races with scoped rollback and multi-root-safe cleanup

Validation

  • npm run lint
  • npm run compile-tests
  • npm run unittest (3,546 passing, 9 pending)
  • npm run compile
  • manually verified cancellation, successful project creation with Python 3.15, registration, and reload persistence

Fixes #518

@rchiodo

Rich Chiodo (rchiodo) commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR.

@StellaHuang95 Stella Huang (StellaHuang95) added the feature-request Request for new features or functionality label Nov 12, 2026
: overrides.findIndex(
(s) =>
!s.workspace && normalizePath(path.resolve(w.uri.fsPath, s.path)) === pwPath,
);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning · Non-blocking recommendation

If a multi-root workspace folder is renamed, its existing setting retains the old workspace qualifier. Neither branch removes that entry, while project loading can still fall back to the matching path; removing the project then leaves it persisted and it reappears after reload. Please preserve the loader's orphaned-qualifier fallback here without removing an entry owned by another live root, and add a renamed-folder regression test.

@rchiodo

Rich Chiodo (rchiodo) commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Reviewed commit: 4965e5e60b8af59c0c2daaee6b4c0a00c457c6ff

Result: 🔴 could-not-verify

Verification details

Verification: Automated verification is best effort. The PR author remains responsible for testing.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Users\rchiodo\AppData\Local\Programs\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "149662dcef3a50145fe0caa2c3435bec5e547d189f0e004515e3d751e32c381a": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found

Test runs: none recorded.

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@rchiodo Rich Chiodo (rchiodo) added the review-auto:approved Automated review: no blocking findings (approval posted). label Nov 12, 2026

@bschnurr Bill Schnurr (bschnurr) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@StellaHuang95
Stella Huang (StellaHuang95) force-pushed the stellahuang-microsoft-issue-518-select-environment-for-project-created-w-b58ca2 branch from 754a672 to 4965e5e Compare November 17, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request Request for new features or functionality review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Select environment for project created with template if no new venv creation

3 participants