Repository navigation
Passing options for fetch - #105
Merged
Merged
Conversation
Updating working branch(passing options for fetch) with dev
Muthurathinam (muthurathinam)
requested review from
Michael Mainer (MIchaelMainer),
dan-silver,
Darrel (darrelmiller) and
Deepak Agrawal (deepak2016)
and removed request for
dan-silver
September 4, 2018 10:09
Muthurathinam (muthurathinam)
requested a review
from Raman Gupta (bullsseye)
September 5, 2018 04:00
| * A package version | ||
| * @NOTE: This should be kept up to date with the version used in package.json. | ||
| * If you are changing this please ensure you are also changing it in package.json. | ||
| */ |
Contributor
There was a problem hiding this comment.
Comment: I'd like for scenarios like this to be checked with either a pre-commit hook script or via CI.
Contributor
Author
There was a problem hiding this comment.
sounds like a very good option. will do that.!
| * @extends | ||
| * support oData params with and without $ prefix | ||
| */ | ||
| oDataQueryNames = oDataQueryNames.concat(oDataQueryNames.map((s) => "$" + s)); |
Contributor
There was a problem hiding this comment.
Not part of this PR but we should include search and format as values in oDataQueryNames
Contributor
Author
There was a problem hiding this comment.
Yeah that is something we have in our plate. will make a different PR for that.
|
|
||
| ```` | ||
|
|
||
| ## .option() and .options() |
Contributor
There was a problem hiding this comment.
Make this a heading 3
Michael Mainer (MIchaelMainer)
previously approved these changes
Sep 5, 2018
Darrel (darrelmiller)
previously approved these changes
Sep 20, 2018
Muthurathinam (muthurathinam)
dismissed stale reviews from Deepak Agrawal (deepak2016) and Darrel (darrelmiller)
via
September 21, 2018 06:54
46566cc
Deepak Agrawal (deepak2016)
approved these changes
Sep 21, 2018
This was referenced Sep 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetch API options
There are node environment specific needs such as passing agent (http(s).Agent instance, allows custom proxy etc.), timeout for request, number of follows for a continuous redirect etc., and these options needs to be passed to fetch call through its RequestInit param (second param).
We have enabled two ways to pass these options for a request.
Note: This configuration applies to all the requests that are made through GraphClient
.optionand.optionsfunctionality.Note: This applies to the particular request
Bugs Fixed: