Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android a file input in the WebView couldn't be used. Without a
fileChooserlistener, tapping it opened nothing and the page got an immediate cancel. With a listener the picker opened, but the chosen files never reached the page: the URI array was built but never passed toonReceiveValue, andcontent://URIs were rewritten asfile://paths. After that the input stopped responding until the WebView was recreated. iOS isn't affected, since WKWebView shows its own picker.The WebView now opens the system document picker (
ACTION_OPEN_DOCUMENT) itself and passes the chosencontent://URIs to the page. The page gets the real name, type and content without any storage permission and without a new dependency.acceptbecomes the picker's MIME filter. An extension with no known type, like.gpx, shows all files instead of hiding the ones the page accepts.multipleenables multi-select. If the view is disposed while the picker is open, the page gets a cancel. The undocumentedfileChooserevent is removed, since it never delivered a result. A TODO marks where an app-provided picker could be plugged in later, as with the popup presenter in #29.