Skip to content

signInStoredUrlStorageKey does not get set when stale values exist in local storage #491

Open

Description

@rrjohnson85

I'm submitting a...

  • Regression (a behavior that used to work and stopped working in a new release)
  • Bug report
  • Performance issue
  • Feature request
  • Documentation issue or request
  • Other... Please describe:

Current behavior

When signInStoredUrlStorageKey is set and stale authData exists in local storage, the URL to redirect to does not get set in local storage.

Expected behavior

I would expect that the URL to redirect to gets set in local storage, within reason. For example if the authData is set and the expiry is clearly expired, the URL should be stored.

What is the motivation / use case for changing the behavior?

If a user does not sign out, but rather lets their session expire or simply closes their browser, the redirection does not work.

Environment

Angular-Token version: 7.0.1
Angular version: 7.1.2

Bundler

  • Angular CLI (Webpack)
  • Webpack
  • SystemJS

Browser:

  • Chrome (desktop) version XX
  • Chrome (Android) version XX
  • Chrome (iOS) version XX
  • Firefox version XX
  • Safari (desktop) version XX
  • Safari (iOS) version XX
  • IE version XX
  • Edge version XX

Activity

  1. rrjohnson85 commented on Feb 14, 2019

    @rrjohnson85
    Author

    I'd be more than happy to take some time and correct the behavior if PR's are welcome. Just let me know.

  2. neroniaky commented on Feb 20, 2019

    @neroniaky
    Owner

    Hi, thanks for opening this issue. PRs are always welcome :).

  3. rrjohnson85 commented on May 17, 2019

    @rrjohnson85
    Author

    @neroniaky finally added a PR, but need to finalize tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions