Skip to content

[stable32] fix(comments): mark comments as read and dismiss notifications in Activity sidebar - #60622

Closed
miaulalala wants to merge 4 commits into
stable32from
backport/60617/stable32
Closed

[stable32] fix(comments): mark comments as read and dismiss notifications in Activity sidebar#60622
miaulalala wants to merge 4 commits into
stable32from
backport/60617/stable32

Conversation

@miaulalala

@miaulalala miaulalala commented May 20, 2026

Copy link
Copy Markdown
Contributor

Backport of #60617 to stable32.

Summary

  • When the Activity app integration is active, comments load in the Activity sidebar instead of the Comments tab
  • markCommentsAsRead() and mention notification dismissal were never called in this code path
  • This left the unread bubble (💬) in the file list and kept mention notifications active
  • Adds a new DELETE /notifications/{id} endpoint to dismiss individual mention notifications by comment ID

Test plan

  • Enable the Activity app
  • Have another user mention you in a file comment
  • Open the file's Activity sidebar — the unread bubble should disappear after viewing
  • Check that the mention notification is dismissed

🤖 Generated with Claude Code

@miaulalala
miaulalala requested review from a team as code owners May 20, 2026 16:25
@miaulalala
miaulalala requested review from ArtificialOwl, leftybournes, nfebe, sorbaugh and susnux and removed request for a team May 20, 2026 16:25
@miaulalala miaulalala changed the title fix(comments): mark comments as read and dismiss notifications in Activity sidebar [stable32] [stable32] fix(comments): mark comments as read and dismiss notifications in Activity sidebar May 20, 2026
@miaulalala miaulalala self-assigned this May 20, 2026
@miaulalala miaulalala added this to the Nextcloud 32.0.10 milestone May 20, 2026
@miaulalala
miaulalala requested a review from janepie May 20, 2026 16:27
@miaulalala
miaulalala force-pushed the backport/60617/stable32 branch from 6866267 to a89e9aa Compare May 20, 2026 16:31
@miaulalala
fix(comments): mark comments as read and dismiss notifications in Act…
4aac879 
…ivity sidebar

Backport of #60617 to stable32.

When the Activity app integration is active, comments are loaded in the
Activity sidebar instead of the Comments tab. The read marker and mention
notification dismissal were never triggered in this path, leaving the
unread bubble in the file list and keeping mention notifications active.

Also adds a new DELETE /notifications/{id} endpoint to dismiss individual
mention notifications by comment ID.

AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala
miaulalala force-pushed the backport/60617/stable32 branch from a89e9aa to 4aac879 Compare May 20, 2026 21:48
@nextcloud-bot nextcloud-bot mentioned this pull request May 20, 2026
Merged
@miaulalala

miaulalala commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

@miaulalala
Merge remote-tracking branch 'origin/stable32' into backport/60617/st…
4351505 
…able32

# Conflicts:
#	dist/comments-comments-tab.js
#	dist/comments-comments-tab.js.license
#	dist/comments-comments-tab.js.map

Co-authored-by: miaulalala <7427347+miaulalala@users.noreply.github.com>

Copilot AI commented May 25, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Done in commit 4351505. I merged origin/stable32 into this branch and resolved the conflicts in dist/comments-comments-tab.js, .license, and .map by keeping the backport’s bundle content so the comments-read fix remains intact. No UI code changed in this conflict-only follow-up, so there’s no new UI screenshot to share.

nextcloud-bot and others added 2 commits May 26, 2026 09:20
@nextcloud-bot @miaulalala
fix(l10n): Update translations from Transifex
dd94f93 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Co-authored-by: miaulalala <7427347+miaulalala@users.noreply.github.com>
@thereisnotime @miaulalala
fix(UserConfig): cast getTypedValue() result to string in getValueBool()
d29697e 
PHP 8.4 made passing non-strings to strtolower() a fatal TypeError.
getTypedValue() can return a non-string under certain conditions, causing
the strtolower() call to throw. The (string) cast guards against this.

Signed-off-by: There Is No TIme <37583483+thereisnotime@users.noreply.github.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>

Co-authored-by: miaulalala <7427347+miaulalala@users.noreply.github.com>

Copilot AI commented May 26, 2026

Copy link
Copy Markdown
Contributor

@copilot please rebase the PR on stable32

Done — the branch has been rebased on top of the latest stable32 and pushed. Current head is d29697e310c.

@nextcloud-bot nextcloud-bot mentioned this pull request May 27, 2026
Merged
@miaulalala

miaulalala commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the conflicts please

This was referenced Jun 1, 2026
Merged
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Jun 17, 2026
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Jun 25, 2026
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Jul 14, 2026
Merged
This was referenced Aug 10, 2026
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 10, 2026
Merged
@blizzz blizzz closed this Sep 10, 2026
@susnux
susnux deleted the backport/60617/stable32 branch October 25, 2026 01:47
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for more than 7 days. As we do not monitor merged or closed pull requests, we are locking this pull request to prevent further comments from getting lost in the noise.
If you discovered any issues with this pull request, please open a new issue instead. In case you want to discuss this pull request or have further questions, please use our forum: https://help.nextcloud.com

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes
@janepie janepie janepie approved these changes
@susnux susnux Awaiting requested review from susnux susnux is a code owner automatically assigned from nextcloud/server-frontend
@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend
@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend
@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

@miaulalala miaulalala

Labels

3. to review Waiting for reviews 32-feedback AI assisted bug feature: activity and notification feature: comments

Projects

None yet

Milestone

Nextcloud 32.0.15

Development

Successfully merging this pull request may close these issues.

9 participants

@miaulalala @CarlSchwan @janepie @AndyScherzinger @blizzz @Altahrim @nextcloud-bot @thereisnotime