Repository navigation
fix(dav): detect truncated CardDAV sync results on all databases - #65939
Merged
Merged
Conversation
SebastianKrupinski
requested review from
a team,
ChristophWurst,
hamza221 and
tcitworld
as code owners
October 26, 2026 16:16
SebastianKrupinski
requested review from
Altahrim,
leftybournes,
salmart-dev and
sorbaugh
and removed request for
a team
October 26, 2026 16:16
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
fix/caldav-sync-token-results
branch
from
October 26, 2026 16:17
06e902d to
c961634
Compare
Contributor
Author
|
/backport to stable35 |
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
marcelklehr
approved these changes
Oct 29, 2026
kesselb
approved these changes
Oct 29, 2026
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On SQLite and Oracle, 0 === $limit is never true, so an incremental result is never marked as truncated. The server then returns the current sync token. The client accepts it and permanently skips every change after the first 2,500.
This happens on the remote side, the server answering the sync request. So it affects anyone syncing from a SQLite or Oracle instance,
Checklist
3. to review, feature component)stable32)AI (if applicable)