This repository was archived by the owner on Mar 25, 2018. It is now read-only.
Merge HTTPS module into HTTP #12
Copy link
Copy link
Open
Description
As of right now, there exists a wonderful HTTP module, which interweaves libuv, the http_parser, v8 and JavaScript into a perfect request and server suite, complete with all the features you could ask for.
Next to that, there is an HTTPS module, with an inherited API that throws OpenSSL onto the network stack and calls it a new module. This sort of oddly explicit inheritance isn't just weird in thought but it also causes side effects, which may include:
- Using
https.request()on an HTTP link (and vice versa), only to get an error for a rather supported action:"Error: Protocol "http:" not supported. Expected "https:"." - Awkward handling of both protocols and both modules to complete the same goal, as neither module can do what the other does
- Incomplete documentation that only shows half of what the module has to offer (or should I say, another module)
And so, my proposal: that we eventually merge the HTTPS module completely into the current HTTP module, allowing:
- HTTPS requests to occur when OpenSSL is present, otherwise, throw error (like current behavior)
- HTTPS server to be created when given proper TLS parameters (ref io.js#1101)
❤️
Reacted by Stefan Duberg, Jimmy Wärting, Nicolas HENRY, Helson Taveras, Sindre Sorhus, devjet and Charles Samborski
Metadata
Metadata
Assignees
Labels
No labels
Activity
feross commentedon Mar 26, 2015
+1
juliangruber commentedon Mar 26, 2015
👍
juliangruber commentedon Mar 26, 2015
What was the originial reasoning to have two modules?
bnoordhuis commentedon Mar 26, 2015
I don't think anyone will disagree with the basic premise. The question is: can it be done without breaking existing code?
@juliangruber No reason that I'm aware of.