Crash reported due to Node.js #34839 #411

Activity

1. mhdawson

   added this to the Milestone 11 milestone on Oct 21, 2020
2. mhdawson commented on Oct 21, 2020

   

   mhdawson

   on Oct 21, 2020

   MemberAuthor

   More actions

   @gabrielschulhof in case you have a chance to take a look before the meeting on Friday.
3. mhdawson commented on Oct 21, 2020

   

   mhdawson

   on Oct 21, 2020

   MemberAuthor

   More actions

   @gabrielschulhof my first thought is that even if there is no user provided finalizer, we've still set it up for the gc to call a Finalize() in js_native_api_v8.cc and therefore there is a race condition if we delete when reference->_finalize_callback is nullptr.
4. mhdawson commented on Oct 30, 2020

   

   mhdawson

   on Oct 30, 2020

   MemberAuthor

   More actions

   Closing since we discussed, and the revert is in place.

   👍React with 👍1Reacted by George Hertz
5. mhdawson

   closed this as completedon Oct 30, 2020