This repository was archived by the owner on Nov 6, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2022. It is now read-only.
rename XX macro in http_parser.h #487
Description
Problem Description
I got a conflict with http_parser.h, which uses the same macro name:
#define XX()
Code to reproduce this issue
#define XX(x) something
Proposed solution
Never use non-descript unqualified macro-names in libs, as these identifier belong to the user and end up breaking their code. So either qualify the define and rename it HTTP_PARSER_XX(), or use the standard X-macro name convention ENTRY().
Activity
freedaun commentedon Jul 16, 2019
I might add that I'm using this code downstream, in the Espressif ESP32. That's probably why this occurs.
bnoordhuis commentedon Jul 16, 2019
This is about the
http_statusandhttp_methodenums? I'm fine with changing those to somethingHTTP_PARSER_qualified. Want to submit a PR?freedaun commentedon Jul 16, 2019
yes.
No.. apparently a replace on XX to HTTP_PARSER_XX works.
thanks.