Skip to content

Add scope.Escape() to Call() - #817

Merged
kkoopa merged 1 commit into
nodejs:masterfrom
Flarna:fix_call_scope_escape
Oct 22, 2018
Merged

kkoopa merged 1 commit into
nodejs:masterfrom
Flarna:fix_call_scope_escape

Conversation

@Flarna

@Flarna Flarna commented Oct 19, 2018

Copy link
Copy Markdown
Member

Added a scope.Escape() in Call() as suggested by @addaleax in #813.

fixes: #813

@kkoopa
kkoopa merged commit 2e5ed4f into nodejs:master Oct 22, 2018
@kkoopa

kkoopa commented Oct 22, 2018

Copy link
Copy Markdown
Collaborator

Thank you for making the PR.

@Flarna
Flarna deleted the fix_call_scope_escape branch October 22, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nan::Callback::Call improperly garbage collects the return value under Node 10.12, causing segfaults

3 participants