String::Length missing #14

Activity

1. jasongin commented on Apr 6, 2017

   

   jasongin

   on Apr 6, 2017

   Member

   More actions

   Most of the time what you want is the length of the utf8 or utf16 encoding: value.Utf8Value().size() or value.Utf16Value().size().

   Maybe there should be a Napi::String::Length() method that calls napi_get_value_string_length() to get the character length. Or maybe we should remove napi_get_value_string_length(), since it's not very useful and a potential source of localization bugs if it is used incorrectly.
2. jasongin commented on Apr 14, 2017

   

   jasongin

   on Apr 14, 2017

   Member

   More actions

   See nodejs/abi-stable-node#226 about removing napi_get_value_string_length().
3. jasongin commented on Apr 27, 2017

   

   jasongin

   on Apr 27, 2017

   Member

   More actions

   Closing because napi_get_value_string_length() was removed in nodejs/node#12496
4. jasongin

   closed this as completedon Apr 27, 2017