Repository navigation
Silence curl for macOS Catalina acid test #2148
Description
- Node Version: N/A
- Platform: macOS Catalina
- Compiler: N/A
- Module: N/A
This is a really small request to add the -s argument for the macOS Catalina acid test to reduce noise
curl -sL https://github.com/nodejs/node-gyp/raw/master/macOS_Catalina_acid_test.sh | bashOutput of the original
$ curl -L https://github.com/nodejs/node-gyp/raw/master/macOS_Catalina_acid_test.sh | bash
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 150 100 150 0 0 1293 0 --:--:-- --:--:-- --:--:-- 1282
100 495 100 495 0 0 1265 0 --:--:-- --:--:-- --:--:-- 1265
Command Line Tools version: 11.5.0.0.1.1588476445Output of the silenced version
$ curl -sL https://github.com/nodejs/node-gyp/raw/master/macOS_Catalina_acid_test.sh | bash
Command Line Tools version: 11.5.0.0.1.1588476445
Activity
rvagg commentedon Jun 4, 2020
Yeah, I did think about asking for that when the PR was merged but I always prefer more verbosity for things like
curl|bashthat make some people uncomfortable. Although aset -xin the script would probably do a more helpful job on that!Open a PR against the instructions to add the
sif you like, I'll +1 it.weiliddat commentedon Jun 4, 2020
Yeah I get that too.
set -xwould help, or maybe just aecho "Disclaimer about this being downloaded from the Internet"?rvagg commentedon Jun 5, 2020
Nah, I don't think that's necessary. I'm personally not concerned about the security of this
curl|bashbecause (a) we control it and (b) it's over https from a trusted site. It's just that a lot of programmers have been programmed to thinkcurl|bashis inherently evil and is an indicator of bad security attitudes. But there's really nothing to be done about that other than be firm when people show up with criticism.For now let's go with the
sin thecurl