You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Inconsistent Order of build_files in WriteAutoRegenerationRule Causes CI Failures #3061
Hey 👋
When running node-gyp, the Makefile generation process produces different outputs on subsequent runs due to the unordered nature of the build_files set in the WriteAutoRegenerationRule function. This inconsistency occurs because sets in Python do not maintain order, leading to varying order of dependencies in the generated Makefile.
This issue causes problems in CI pipelines that compare file hashes, as the differing order results in false positives for changes. To ensure a stable and consistent build process, the order of build_files should be explicitly sorted before being used in the Makefile generation.
Activity
cclauss commentedon Aug 19, 2024
ben-zalekta-lmnd commentedon Aug 19, 2024
#3062
@cclauss Can you check this one?
I am not sure why. But it seems like I can't link the pr to the issue.