Repository navigation
Windows build failure #102
Description
https://ci.nodejs.org/job/node-compile-windows/25607/label=win-vs2017/console
08:45:56 mksnapshot.cc
08:46:11 Creating library c:\workspace\node-compile-windows\Release\mksnapshot.lib and object c:\workspace\node-compile-windows\Release\mksnapshot.exp
08:46:20 mksnapshot.vcxproj -> c:\workspace\node-compile-windows\Release\\mksnapshot.exe
08:46:20 generating: "Release\obj\generate_snapshot\/embedded.S" "Release\obj\generate_snapshot\/snapshot.cc"
08:46:22 Assembling Release\obj\generate_snapshot\\embedded.S...
08:46:22 Release\obj\generate_snapshot\\embedded.S(1): error A2008: syntax error : / [c:\workspace\node-compile-windows\tools\v8_gypfiles\generate_snapshot.vcxproj]
Activity
refack commentedon Mar 31, 2019
Seems like the generator doesn't handle
\in paths:Where
\b=\0x08refack commentedon Mar 31, 2019
node-v8/deps/v8/src/snapshot/embedded-file-writer.cc
Line 644 in 3c649ec
This doesn't work as expected (and BTW this is C++20)
Now that I think of it this is probably related to nodejs/node#27017. This is a line from
global_intermediate\torque-output-root\torque-generated\builtins-array-from-dsl-gen.ccrefack commentedon Mar 31, 2019
Pushed a temporary patch as 42f8116
https://ci.nodejs.org/job/node-test-commit-node-v8/229/
refack commentedon Mar 31, 2019
Ok, seems like we were missing another small thing
node-v8/tools/v8_gypfiles/v8.gyp
Lines 2691 to 2693 in 17d955f
17d955f
https://ci.nodejs.org/job/node-test-commit-windows-fanned/26076/
refack commentedon Mar 31, 2019
Rebased 3c649ec...506610d
Windows CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/26080/ ✔️
Pushed to nodejs/node/canary-base