stream, test: Add test for _readableState.needReadable and _readableState.emittedReadable #10230

Activity

1. mcollina

   added

   streamIssues and PRs related to Node.js streams.Issues and PRs related to Node.js streams.

   testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.

   on Dec 11, 2016
2. mcollina commented on Dec 11, 2016

   

   mcollina

   on Dec 11, 2016

   SponsorMemberAuthor

   More actions

   This is really a good issue if someone wants to dig into how streams work. I'm happy to help.
3. joyeecheung commented on Dec 12, 2016

   

   joyeecheung

   on Dec 12, 2016

   Member

   More actions

   Hi, I am interested in the internals of streams since folks in my company have bumped into some perf issues related to it. I would love to spend some time digging into it and learning how it works :)

   👍React with 👍1Reacted by Gibson Fahnestock
4. mcollina commented on Dec 12, 2016

   

   mcollina

   on Dec 12, 2016

   SponsorMemberAuthor

   More actions

   @joyeecheung please go ahead and prep a PR!
5. joyeecheung commented on Dec 12, 2016

   

   joyeecheung

   on Dec 12, 2016

   Last edited by joyeecheung

   Member

   More actions

   I have attempted a PR for needReadable(#10241), please take a look.

   Since there is #10214 involved I might need a little bit more time to get my head around emittedReadable.
6. mcollina commented on Dec 13, 2016

   

   mcollina

   on Dec 13, 2016

   SponsorMemberAuthor

   More actions

   @joyeecheung I would like to have a test for emittedReadable before a fix for #10214 happen. I would like to track possible regression, so write a test for what it is doing now.
7. joyeecheung commented on Dec 13, 2016

   

   joyeecheung

   on Dec 13, 2016

   Member

   More actions

   @mcollina OK, working on it :)
8. italoacasas commented on Dec 13, 2016

   

   italoacasas

   on Dec 13, 2016

   More actions

   @mcollina this is duplicated ? #8683
9. mcollina commented on Dec 13, 2016

   

   mcollina

   on Dec 13, 2016

   Last edited by mcollina

   SponsorMemberAuthor

   More actions

   Yes but not entirely. We can close this in fact, my bad.
10. mcollina

    closed this as completedon Dec 13, 2016
11. joyeecheung

    added a commit that references this issue on Dec 13, 2016

    stream, test: test _readableState.needReadable

    ...

    6633c5c
12. mcollina

    added a commit that references this issue on Dec 16, 2016

    stream, test: test _readableState.emittedReadable

    ...

    8127501
13. italoacasas

    added a commit that references this issue on Dec 17, 2016

    stream, test: test _readableState.emittedReadable

    ...

    28ffd59
14. cjihrig

    added a commit that references this issue on Dec 20, 2016

    stream, test: test _readableState.emittedReadable

    ...

    8ddbd53
15. MylesBorins

    added 4 commits that reference this issue on Jan 23, 2017

    stream, test: test _readableState.emittedReadable

    ...

    f26213a

    stream, test: test _readableState.emittedReadable

    ...

    9fa1e7d

    stream, test: test _readableState.emittedReadable

    ...

    1f6b10d

    stream, test: test _readableState.emittedReadable

    ...

    a023886
16. MylesBorins

    added 2 commits that reference this issue on Jan 31, 2017

    stream, test: test _readableState.emittedReadable

    ...

    9a84162

    stream, test: test _readableState.emittedReadable

    ...

    271f578