Skip to content

doc,vm: warn more prominently against executing untrusted code #11550

Closed

Description

@bnoordhuis

The vm module is not a security mechanism. There used to be a prominent warning against executing untrusted code but it seems to have been removed in recent years.

I think it would be good to bring it back because the language around sandboxing can mislead users into thinking the vm module is something it's not.

Activity

  1. added
    docIssues and PRs related to Node.js documentation.
    good first issueIssues that are suitable for first-time contributors.
    vmIssues and PRs related to the vm subsystem.
    on Feb 25, 2017
  2. krydos commented on Feb 25, 2017

    @krydos
    Contributor

    Sound good as first contribution. Can I try to do it please?

    Will it be ok to put this as Note: ... somewhere at the end of the first section?

  3. bnoordhuis commented on Feb 25, 2017

    @bnoordhuis
    MemberAuthor

    @krydos Yes, that's a good place for it.

  4. bnoordhuis commented on Mar 17, 2017

    @bnoordhuis
    MemberAuthor

    Fixed by 2e74b0d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docIssues and PRs related to Node.js documentation.good first issueIssues that are suitable for first-time contributors.vmIssues and PRs related to the vm subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions