Skip to content

Add vcbuild cpplint and and update CONTRIBUTING.md #11816

Closed
Closed
Add vcbuild cpplint and and update CONTRIBUTING.md#11816
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.good first issueIssues that are suitable for first-time contributors.windowsIssues and PRs related to the Windows platform.

Description

@gibfahn
gibfahn
opened on Mar 12, 2017
  • Platform: windows
  • Subsystem: test, cpplint

Implement cpplint for vcbuild.bat (i.e. a windows version of the equivalent Makefile target). Then lint can be implemented as jslint and cpplint.

See #11151 (comment).

The line in #11151 can then be updated to reflect this addition (i.e. suggest that people use vcbuild lint).

Optimistically marking this as a good first contribution as it should be a self-contained bit of Windows syntax to run tools/cpplint.py and tools/check-imports.py.

If you'd like to have a go at this then please comment here to let other people know. You can follow the guide in CONTRIBUTING.md to submit a PR.

Activity

  1. gibfahn
    added
    good first issueIssues that are suitable for first-time contributors.
    windowsIssues and PRs related to the Windows platform.
    on Mar 12, 2017
  2. mscdex
    added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    on Mar 12, 2017

  3. liusy182 commented on Mar 14, 2017

    @liusy182
    liusy182
    on Mar 14, 2017

    I would like to give a try on this -P

  4. gibfahn commented on Mar 14, 2017

    @gibfahn
    gibfahn
    on Mar 14, 2017
    MemberAuthor

    @liusy182 Great, go for it! If you have any issues let us know.

  5. liusy182
    added a commit that references this issue on Mar 15, 2017

    build: add cpp linting to windows build

    3f6c5a9
  6. jasnell
    closed this as completedin 379eec3on Mar 17, 2017
  7. italoacasas
    added a commit that references this issue on Mar 20, 2017

    build: add cpp linting to windows build

    80949f3
  8. jungx098
    added a commit that references this issue on Mar 21, 2017

    build: add cpp linting to windows build

    7474333
  9. kfarnung
    added a commit that references this issue on Aug 16, 2017

    build: add cpp linting to windows build

    1bba740
  10. MylesBorins
    added a commit that references this issue on Sep 19, 2017

    build: add cpp linting to windows build

    66cdcd9
  11. sjarmak
    added a commit that references this issue on Jul 27, 2026

    build: add cpp linting to windows build

    379eec3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.good first issueIssues that are suitable for first-time contributors.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions