Switch ClosureLinter to other linter. #1253

Activity

1. yosuke-furukawa commented on Mar 25, 2015

   

   yosuke-furukawa

   on Mar 25, 2015

   MemberAuthor

   More actions

   @chrisdickinson I guess you also have an interest to switch other linter. #1243 (comment)
   This work is great!
2. mscdex

   added

   discussIssues opened for discussion and feedback.Issues opened for discussion and feedback.

   metaIssues and PRs related to the general management of the project.Issues and PRs related to the general management of the project.

   on Mar 25, 2015
3. brendanashworth commented on Mar 25, 2015

   

   brendanashworth

   on Mar 25, 2015

   Contributor

   More actions

   +1. However, we have to decide whether we should be able to run the linter without building io.js; the closure linter was written in Python, while both jshint and eslint are in JavaScript.
4. jbergstroem commented on Mar 25, 2015

   

   jbergstroem

   on Mar 25, 2015

   Member

   More actions

   I'd be ok with only being able to execute things like tests, benchmarks and qa tools after a build.
5. chrisdickinson commented on Mar 25, 2015

   

   chrisdickinson

   on Mar 25, 2015

   Contributor

   More actions

   Yep, the previous status was that we'd be okay switching to eslint / javascript-based tools, since they run after the tests (and thus, we can assume we have at least one working iojs around).

   I lean towards eslint (or eslint+jscs), since it's got a pluggable rule system. I have a work in progress branch that switches things over, if anyone would like to take it over. The difficulty was striking a balance between leaning useful rules on and avoiding code churn.
6. silverwind commented on Mar 25, 2015

   

   silverwind

   on Mar 25, 2015

   Contributor

   More actions

   eslint looks pretty flexible. One thing I'd like to avoid is wrapping code in exclusion rules like this:

   /* eslint-disable new-cap */
   DTRACE_HTTP_CLIENT_REQUEST(this, this.connection);
   COUNTER_HTTP_CLIENT_REQUEST();
   /* eslint-enable new-cap */

   The new-cap rule assumes that the any capitalized variable is a constructor. Maybe the 'pluggable' system would allow us to add special rules like for these DTRACE constants?
7. yosuke-furukawa

   added 2 commits that reference this issue on May 9, 2015

   tools: replace closure-linter with eslint

   ...

   f9dd34d

   lib: fix eslint styles

   ...

   19ffb5c
8. yosuke-furukawa commented on May 9, 2015

   

   yosuke-furukawa

   on May 9, 2015

   MemberAuthor

   More actions

   Switched closure-linter to eslint! Thanks! f9dd34d 19ffb5c
9. yosuke-furukawa

   closed this as completedon May 9, 2015
10. Fishrock123

    added 2 commits that reference this issue on May 19, 2015

    tools: replace closure-linter with eslint

    ...

    367e221

    lib: fix eslint styles

    ...

    edb4cb6