Repository navigation
make check should not fail for release tarballs #14513
Description
- Version: 8.2.1
- Platform: Linux flip 4.10.0-28-generic docs: replace all instances of node.js with io.js because trademark. #32-Ubuntu SMP Fri Jun 30 05:32:18 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
PR #13658 introduced a hard-failing linter in case the linter dependencies are not included.
This happens to be the case for at least release 8.2.1, and as part of normal packaging procedures we run make check to verify that everything still works as it should. It seems reasonable to expect make check to only fail if there are problems with the code.
A linter not being available in the release tarball is IMHO not a reason for the included tests to fail.
Activity
Fishrock123 commentedon Jul 28, 2017
cc @gibfahn
gibfahn commentedon Jul 28, 2017
If we don't include the linter in the release tarball then I agree that it doesn't make sense to fail tests. I guess the better change would be to change the linter check in https://github.com/nodejs/node/blob/master/Makefile#L915 from
tools/eslint/lib/eslint.jstotools/eslint/.Is there a way to detect that it's a release tarball (rather than an eslint upgrade gone wrong)?
jellelicht commentedon Sep 11, 2017
@gibfahn I do not really see how development tooling is relevant to a release tarball.
IOW, why not just have a make target (make lint?) which is invoked as part of regular development QA, but not at all related to the release-related
make check.gibfahn commentedon Sep 11, 2017
@jellelicht at the moment
make checkis just an alias formake test, there is no release-specific Makefile tooling:node/Makefile
Line 117 in 640b206
build: don't fail `make test` on source tarballs
build: don't fail `make test` on source tarballs
build: don't fail `make test` on source tarballs
build: don't fail `make test` on source tarballs
build: don't fail `make test` on source tarballs
build: don't fail `make test` on source tarballs