util: unenumerable properties should be visible #1598

Activity

1. silverwind

   added

   utilIssues and PRs related to the built-in util module.Issues and PRs related to the built-in util module.

   on May 3, 2015
2. petkaantonov commented on May 3, 2015

   

   petkaantonov

   on May 3, 2015

   Contributor

   More actions

   Though these views are not equivalent. The equivalent view in chrome is when you expand the properties and in that view the unenumerable properties are greyed out. Perhaps there should be some kind of enumerability marker in the util view as well?
3. silverwind commented on May 3, 2015

   

   silverwind

   on May 3, 2015

   ContributorAuthor

   More actions

   True, one could do something like [Getter/enumerable], but I think that could be too verbose.

   As I see it, everything is better than {}.
4. monsanto commented on May 3, 2015

   

   monsanto

   on May 3, 2015

   Contributor

   More actions

   This is intentional, unenumerable properties need the showHidden flag set to show:

   > require('util').inspect(o, {showHidden: true})
   '{ [a]: [Getter] }'
   

   although I guess whether or not this is desirable is up for discussion. Keep in mind on the REPL this would get obnoxious quick since arrays would show their length attribute.
5. silverwind commented on May 3, 2015

   

   silverwind

   on May 3, 2015

   ContributorAuthor

   More actions

   Interesting. This is what Firefox does:

   > var o = {}; Object.defineProperty(o, "a", {get: function(){}})
   Object { , 1 more… }
   > var o = {}; Object.defineProperty(o, "a", {get: function(){}, enumerable:true})
   Object { a: Getter }
6. bnoordhuis commented on Jun 6, 2015

   

   bnoordhuis

   on Jun 6, 2015

   Member

   More actions

   Ping @silverwind, what is the status of this issue?
7. silverwind commented on Jun 6, 2015

   

   silverwind

   on Jun 6, 2015

   ContributorAuthor

   More actions

   I think we could change showHidden to default to true, with special handling to hide language builtin unenumerable properties. This would be pretty much what the Chrome console now does. If we agree on that, I can do a PR.
8. vkurchatkin commented on Jun 6, 2015

   

   vkurchatkin

   on Jun 6, 2015

   Contributor

   More actions

   -1 from me. I don't think we should try to replicate Chrome console
9. chrisdickinson commented on Jun 6, 2015

   

   chrisdickinson

   on Jun 6, 2015

   Contributor

   More actions

   I think we could change showHidden to default to true

   I'm not opposed to either making it default to true for the REPL/console only. Where ansi colors are enabled we should probably use them to indicate non-enumerability of properties as well.
10. silverwind commented on Jun 7, 2015

    

    silverwind

    on Jun 7, 2015

    ContributorAuthor

    More actions

    Yeah, would keep it REPL-only. I could see property names colored blue as normal properties and magenta as unenumerable ones. Right now, we only color the value (yellow).
11. silverwind commented on Aug 22, 2015

    

    silverwind

    on Aug 22, 2015

    ContributorAuthor

    More actions

    Decided against pursuing this further because having showHidden flipped just on the REPL to make this work seems wrong. Also, blue ansi color is unreadable on Windows according to a comment. If we ever decide to add 256 color support to inspect, we might be able to revisit this issue.
12. silverwind

    closed this as completedon Aug 22, 2015