Please give the trailing slash back to os.tmpdir() #1669

Activity

1. mscdex commented on May 10, 2015

   

   mscdex

   on May 10, 2015

   Contributor

   More actions

   Why not use path.join() or similar path methods?

   $ iojs
   > path.join('/oh/my/xxx/////', 'bar')
   '/oh/my/xxx/bar'
   
2. mscdex

   added

   osIssues and PRs related to the os subsystem.Issues and PRs related to the os subsystem.

   on May 10, 2015
4. rlidwka commented on May 10, 2015

   

   rlidwka

   on May 10, 2015

   Contributor

   More actions

   If the string "/" comes from the user environment (though hardly possible), gets trimmed into "", what directory does it represent (and on what platform)?

   That's true actually:

   $ TEMP=/ ~/io.js/iojs  -e 'console.log(JSON.stringify(require("os").tmpdir()))'
   ""

   / should not be removed if it's the only character there.

   dirname works correctly in that case:

   $ cat /test.js
   console.log(__dirname)
   $ ~/io.js/iojs /test.js
   /
6. Fishrock123 commented on May 10, 2015

   

   Fishrock123

   on May 10, 2015

   Contributor

   More actions

   cc @tellnes
7. brendanashworth commented on May 10, 2015

   

   brendanashworth

   on May 10, 2015

   Contributor

   More actions

   Perhaps semver-major changes aren't looked at hard enough... maybe we should introduce a hard minimum amount of reviewers for a major change, say 3.
8. tellnes commented on May 10, 2015

   

   tellnes

   on May 10, 2015

   Contributor

   More actions

   We could change it so we remove all trailing slashes and keep one if there is no other characters there?
9. benjamingr commented on May 10, 2015

   

   benjamingr

   on May 10, 2015

   Member

   More actions

   @tellnes Yeah, that sounds like a solid workaround.

   @jakwings would that satisfy you? I realize this is a breaking change and that you'd have to normalize it through the library, but isn't that a one-time thing and the new behavior makes more sense?
12. tellnes commented on May 11, 2015

    

    tellnes

    on May 11, 2015

    Contributor

    More actions

    So remove trailing path.sep then, but keep one if there is no other characters?
14. cjihrig

    added a commit that references this issue on May 13, 2015

    os: refine tmpdir() trailing slash stripping

    ...

    7693705
15. cjihrig commented on May 13, 2015

    

    cjihrig

    on May 13, 2015

    Contributor

    More actions

    As of 7693705, trailing slashes will not be stripped from / or C:\. Additionally, only slashes relevant to the current operating system will be stripped.
16. cjihrig

    closed this as completedon May 13, 2015