UNREACHABLE in WorkerThreadsTaskRunner::PostDelayedTask #22157

Activity

1. devsnek

   added

   inspectorIssues and PRs related to the V8 inspector protocol.Issues and PRs related to the V8 inspector protocol.

   on Aug 6, 2018
2. devsnek

   changed the title [-]UNREACHABLE in NodePlatform::CallDelayedOnWorkerThread[/-] [+]UNREACHABLE in WorkerThreadsTaskRunner::PostDelayedTask[/+] on Aug 6, 2018
3. devsnek commented on Aug 6, 2018

   

   devsnek

   on Aug 6, 2018

   MemberAuthor

   More actions

   would this diff work? its sorta copied from the foreground runner's PostDelayedTask

   diff --git a/src/node_platform.cc b/src/node_platform.cc
   index 6a3ae2e5dc..c41e6624e8 100644
   --- a/src/node_platform.cc
   +++ b/src/node_platform.cc
   @@ -46,7 +46,15 @@ void WorkerThreadsTaskRunner::PostTask(std::unique_ptr<Task> task) {
   
    void WorkerThreadsTaskRunner::PostDelayedTask(std::unique_ptr<v8::Task> task,
                                                  double delay_in_seconds) {
   -  UNREACHABLE();
   +  uv_timer_t timer;
   +  timer.data = std::move(task).get();
   +  uint64_t delay_millis = static_cast<uint64_t>(delay_in_seconds + 0.5) * 1000;
   +  uv_timer_init(uv_default_loop(), &timer);
   +  uv_timer_start(&timer, [](uv_timer_t* timer) {
   +    auto task = reinterpret_cast<v8::Task*>(timer->data);
   +    task->Run();
   +  }, delay_millis, 0);
   +  uv_unref(reinterpret_cast<uv_handle_t*>(&timer));
    }
   
    void WorkerThreadsTaskRunner::BlockingDrain() {
4. addaleax commented on Aug 6, 2018

   

   addaleax

   on Aug 6, 2018

   Member

   More actions

   @devsnek Well … accessing the default loop is not thread-safe (and that loop does not run in the background). So, for that general approach to work, I think we’d need to have a separate loop/thread for the delayed tasks?
5. devsnek commented on Aug 6, 2018

   

   devsnek

   on Aug 6, 2018

   MemberAuthor

   More actions

   @addaleax i think i'll just leave this to someone who knows more about it :P
6. addaleax

   added

   v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.

   on Aug 6, 2018
7. addaleax commented on Aug 6, 2018

   

   addaleax

   on Aug 6, 2018

   Member

   More actions

   I think I’m working on enough things for now, but if somebody wants to take this and feels up for it, I’m happy to support as needed
8. devsnek

   added

   help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.

   on Aug 6, 2018
9. alexkozy commented on Aug 17, 2018

   

   alexkozy

   on Aug 17, 2018

   Member

   More actions

   It looks like this crash is reproducible in Node 10.9.0 and it breaks DevTools console in dedicated frontend and in ndb.
   I am wondering what is right label to mark issues like this next time to make it release blocker? I will work on fix tomorrow.
10. alexkozy

    closed this as completedin b1e2612on Aug 21, 2018
11. addaleax

    added a commit that references this issue on Aug 28, 2018

    src: implement v8::Platform::CallDelayedOnWorkerThread

    ...

    b3dab8c
12. targos

    added 2 commits that reference this issue on Sep 3, 2018

    src: implement v8::Platform::CallDelayedOnWorkerThread

    ...

    02e3daa

    src: implement v8::Platform::CallDelayedOnWorkerThread

    ...

    4d802f0
13. blattersturm

    added a commit that references this issue on Nov 3, 2018

    src: implement v8::Platform::CallDelayedOnWorkerThread

    ...

    a14e56b
14. sjarmak

    added a commit that references this issue on Jul 27, 2026

    src: implement v8::Platform::CallDelayedOnWorkerThread

    ...

    b1e2612