Using GitHub Lock App for closed issues/PRs on NodeJS core?

@bcoe

Hi,

This suggestion came from Twitter discussion started by @bcoe (link)

GitHub App lock locks closed issues and pull requests after a period of inactivity.
How about using this App on NodeJS core repo?

The only concern I see is comments related to backporting in Pull Requests.
The PR is still open to comments from collaborators so it shouldn't be a concern. And in a rare case, a collaborator can always unlock the PR if comments/response is required from a non-collaborator.

Regards,
Trivikram

has there been a problem with comments in closed issues that shouldn't be in those closed issues? if so this sounds ok.

there were several cases where substantial project contributions occurred that came through collaborations in closed PRs / issues.
inhibiting write permissions on artifacts by default can make our project look less open

I don't think locking a closed issue after a period of inactivity is particularly useful? Closing an issue after a period of inactivity on the other hand, is more useful.

Unless there has been a problem that would be fixed by locking after some period of time, I'd favor leaving as is.

I'd be in favor of auto-closing old issues. We have a long (loooong) backlog of probably-stale issues that no one is looking at, with many where discussion has meandered so much that no one is really sure anymore what they're even about.

There are 3 options in the end:

Don't close stale issues and don't lock them
Close stale issues but don't lock them
Close stale issues and lock them

IMO, option 2 is a fair trade-off and still allows conversations but prunes the backlog.

(Just my 2 cents ☺️)

is interesting, close but don't lock, but I think we'd want to do it based on activity, not time of opening. The literally oldest issues by open date actually have some activity, some of them are long-term tracking issues. Its more in the middle (not oldest, not most recent) where there seem to be some issues that could be dropped if there is no activity.

@sam-github

@sam-github This can be done with the suggested bot, (example: 2 months w/o activities). Then you can "announce" the close and give another grace period so the user can bump the issue again (if still relevant).

Example here: nuxt/nuxt#3948 (comment)

@manniL

@manniL That last seems really helpful to me. I think a few people have been basically doing this manually, @Trott and @bnoordhuis leap to mind, and it must be pretty tedious. Automating the nudge and closing out the issue if no one responds seems really useful.

Is the locking which was done in the example you linked required, or can it just be closed?

@sam-github

@sam-github lock and stale are two different bots, so no, you can use only stale and don't lock up issues at all ☺️ You can also prevent issues with a certain label from becoming stale.

Our config for the stale bot can be found here ☺️

This issue is now stale 😄 What should we do?

@targos

After going through the comments, looks like the support has primarily been for stale bot and not lock bot. I've created a new issue at #28798, and closing this one.

Thank you @targos for doing the work of stale bot for this issue 😄

Navigation Menu

Repository navigation

Using GitHub Lock App for closed issues/PRs on NodeJS core? #25209

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Using GitHub Lock App for closed issues/PRs on NodeJS core? #25209

Description

Activity

devsnek commented on Dec 24, 2018

gireeshpunathil commented on Dec 25, 2018

joyeecheung commented on Dec 25, 2018

mhdawson commented on Jan 2, 2019

bnoordhuis commented on Jan 8, 2019

TheAlexLichter commented on Jan 8, 2019

sam-github commented on Jan 8, 2019

TheAlexLichter commented on Jan 8, 2019

sam-github commented on Jan 8, 2019

TheAlexLichter commented on Jan 8, 2019

targos commented on Jul 21, 2019

trivikr commented on Jul 21, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions