Skip to content

fs: make rmdir() emfileWait handle ENFILE #30482

Closed
Closed
fs: make rmdir() emfileWait handle ENFILE#30482
Labels
fsIssues and PRs related to file-system APIs and the fs module.good first issueIssues that are suitable for first-time contributors.

Description

@bnoordhuis
bnoordhuis
opened on Nov 14, 2019
  1. EMFILE: current process is out of file descriptors
  2. ENFILE: system is out of file descriptors

The fs.rmdir() logic in lib/internal/fs/rimraf.js currently handles the former but not the latter:

node/lib/internal/fs/rimraf.js

Lines 43 to 44 in ed40123

if (err.code === 'EMFILE' && timeout < options.emfileWait)
return setTimeout(_rimraf, timeout++, path, options, CB);

Both are (hopefully) transient errors though and should be handled identically.

Since ENFILE is difficult to test for, I think it's okay to omit a regression test.

Activity

  1. bnoordhuis
    added
    fsIssues and PRs related to file-system APIs and the fs module.
    good first issueIssues that are suitable for first-time contributors.
    on Nov 14, 2019

  2. thangktran commented on Nov 14, 2019

    @thangktran
    thangktran
    on Nov 14, 2019
    Contributor

    I would like to work on this issue

  3. bnoordhuis commented on Nov 14, 2019

    @bnoordhuis
    bnoordhuis
    on Nov 14, 2019
    MemberAuthor

    @thangktran Go for it :)

  4. cjihrig
    added a commit that references this issue on Nov 27, 2019

    fs: add ENFILE to rimraf retry logic

    74f8196
  5. cjihrig
    closed this as completedin 74f8196on Nov 27, 2019
  6. addaleax
    added a commit that references this issue on Nov 30, 2019

    fs: add ENFILE to rimraf retry logic

    3475f9b
  7. targos
    added a commit that references this issue on Jan 13, 2020

    fs: add ENFILE to rimraf retry logic

    0b88bbd
  8. BethGriggs
    added a commit that references this issue on Feb 6, 2020

    fs: add ENFILE to rimraf retry logic

    4fffb42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fsIssues and PRs related to file-system APIs and the fs module.good first issueIssues that are suitable for first-time contributors.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions