PR diffs are showing pages of unrelated warnings about "check annotations" #31347

Activity

1. richardlau commented on Jan 13, 2020

   

   richardlau

   on Jan 13, 2020

   Member

   More actions

   These started appearing after we enabled builds using GitHub Actions workflows in #31153.

   I attempted to get rid of them in #31311 but it looks like it only shows the first 10 failing checks so the ones I fixed are gone but it's now showing the next 10.
2. richardlau commented on Jan 13, 2020

   

   richardlau

   on Jan 13, 2020

   Member

   More actions

   I think I've figured out what's going on... it just so happens that the warning messages coming out of the Visual Studio C/C++ compiler happen to match the regular expression in the tsc problem matcher installed by the setup-node action we use to run npx envinfo prior to the build.
   

   node/.github/workflows/CI.yml

   Lines 22 to 27 in f4a4a1a

   	- name: Use Node.js ${{ matrix.node-version }}
   	uses: actions/setup-node@v1
   	with:
   	node-version: 13.x
   	- name: Environment Information
   	run: npx envinfo

   I don't see a way to turn off this problem matcher. Not using setup-node would prevent the problem matcher being installed.

   cc @gengjiawen

   🎉React with 🎉3Reacted by Sam Roberts, Jiawen Geng and Alex Yang

   👀React with 👀1Reacted by Sam Roberts
3. sam-github commented on Jan 13, 2020

   

   sam-github

   on Jan 13, 2020

   ContributorAuthor

   More actions

   I don't think the annotations are helpful to collaborators, and I think they may be actively discouraging and confusing to new contributors. Its not an emergency, but if they could be disabled, I think it would be an improvement to the contribution experience.

   👍React with 👍1Reacted by Richard Lau
4. richardlau commented on Jan 14, 2020

   

   richardlau

   on Jan 14, 2020

   Member

   More actions

   GitHub hosted runners already have a version of Node.js installed so we don't need to use setup-node to install another one to run npx envinfo. PR to remove it: #31349
5. richardlau

   added

   buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.

   on Jan 14, 2020
6. richardlau

   added a commit that references this issue on Jan 16, 2020

   build: do not use setup-node in build workflows

   ...

   9bfa4a9
7. richardlau

   closed this as completedin 9bfa4a9on Jan 16, 2020
8. codebytere

   added a commit that references this issue on Mar 14, 2020

   build: do not use setup-node in build workflows

   ...

   37e386f
9. MylesBorins

   added 2 commits that reference this issue on Apr 2, 2020

   build: do not use setup-node in build workflows

   ...

   9a3e059

   build: do not use setup-node in build workflows

   ...

   46f83df