Repository navigation
tlsSocket.setMaxSendFragment results in an abort #38169
Description
- Version: v14.15.1
- Platform: Linux 5.8.0-38-generic The binary and long term compatibility with node #43~20.04.1-Ubuntu SMP Tue Jan 12 16:39:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
- Subsystem: tlsSocket.setMaxSendFragment
What steps will reproduce the bug?
Setup a node instance,
» node
and run the following javascript code.
new tls.TLSSocket().setMaxSendFragment();
Then the node instance occurs an abort.
How often does it reproduce? Is there a required condition?
This abort can always be triggered following the steps above.
What is the expected behavior?
If any error occurs, an exception or other similar error-reporting stuff should be thrown. There is no reason to abort the whole node process.
What do you see instead?
» node
Welcome to Node.js v14.15.1.
Type ".help" for more information.
> new tls.TLSSocket().setMaxSendFragment();
node[21216]: ../src/node_crypto.cc:2113:static void node::crypto::SSLWrap<Base>::SetMaxSendFragment(const v8::FunctionCallbackInfo<v8::Value>&) [with Base = node::TLSWrap]: Assertion `args.Length() >= 1 && args[0]->IsNumber()' failed.
1: 0xa03530 node::Abort() [node]
2: 0xa035ae [node]
3: 0xb3673a node::crypto::SSLWrap<node::TLSWrap>::SetMaxSendFragment(v8::FunctionCallbackInfo<v8::Value> const&) [node]
4: 0xbe369b [node]
5: 0xbe4c46 [node]
6: 0xbe52c6 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [node]
7: 0x13ff259 [node]
[1] 21216 abort (core dumped) node
Activity
EladKeyshawn commentedon Apr 9, 2021
@aduh95 I'm taking a look into seems like an easy fix
tls: fix `tlsSocket.setMaxSendFragment` abort
tls: fix `tlsSocket.setMaxSendFragment` abort