test_runner: add timeout for tests

What is the problem this feature will solve?

currently - tests can easily be stuck or never end, which makes it very hard to understand and locate where your problem might originate

for example, this program will be very hard to debug:

test('top level', { concurrency: 2 }, async (t) => {
  await t.test('endless', () => new Promise(() => {
    setTimeout(() => {}, /* Large number */);
  }));


  // ... many other tests
});

What is the feature you are proposing to solve the problem?

add a timeout to tests running via node:test, I propose adding a default timeout that will be configurable
one of the most important parts of testing is failing fast and knowing what the failure is, and timing out will help determine which test is misfunctioning

What alternatives have you considered?

No response

@benjamingr

CC @benjamingr Please ping relevant people and add a label?

@nodejs/test_runner

Yes, this is a good idea and I am in favor. Is this something you'd like to work on?

Yes, this is a good idea and I am in favor. Is this something you'd like to work on?

Yes, assuming no objections

No objections - this is something we should definitely support.

test_runner: support timeout for tests

feat: support timeout for tests

test_runner: support timeout for tests

Has this been implemented?

@bitflower

Yeah there is a timeout parameter now check the test runner docs. @bitflower

@benjamingr

Thanks for the feedback @benjamingr ! Sorry to not report back. I had found it in the meantime (it's different to e.g. mocha).

Navigation Menu

Repository navigation

test_runner: add timeout for tests #43490

What is the problem this feature will solve?

What is the feature you are proposing to solve the problem?

What alternatives have you considered?

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

test_runner: add timeout for tests #43490

Description

What is the problem this feature will solve?

What is the feature you are proposing to solve the problem?

What alternatives have you considered?

Activity

MoLow commented on Jun 19, 2022

VoltrexKeyva commented on Jun 19, 2022

benjamingr commented on Jun 19, 2022

MoLow commented on Jun 19, 2022

cjihrig commented on Jun 19, 2022

bitflower commented on Jul 10, 2023

benjamingr commented on Jul 19, 2023

bitflower commented on Jul 19, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions