Repository navigation
Nested GC callback #44046
Description
Activity
Weak phantom callbacks run during the prologue or epilogue of major GCs1 so the output you're seeing is not unexpected, just an artifact of how V8 implements them.
1 The relevant method is
Heap::CollectGarbage()in deps/v8/src/heap/heap.cc.Thanks. So is it wrong to calculate the elapsed time for each GC type through prologue and epilogue callbacks ?
Yes. No. Depends on whether you count kGCTypeProcessWeakCallbacks as a separate type. :-)
Get it ! Thank you very much !
- added a commit that references this issue
on Aug 10, 2022 - added a commit that references this issue
on Aug 16, 2022 - added a commit that references this issue
on Aug 23, 2022 - added a commit that references this issue
on Sep 5, 2022 - added 2 commits that reference this issue
on Jan 3, 2023
Version
v19.0.0-pre
Platform
Darwin Kernel Version 20.3.0
Subsystem
perf_hooks
What steps will reproduce the bug?
The example code that triggers this bug has not been found. I found this bug in my project. I add some logs into
node_perf.cc.and found the log as follows.
This will make the value of gc
durationinaccurate (node_perf.cc). The 4 and 16 is defined inGCType.How often does it reproduce? Is there a required condition?
it is difficult to reproduce currently.
What is the expected behavior?
it should be 4 4 16 16.
What do you see instead?
4 16 16 4.
Additional information
cc @bnoordhuis