Skip to content

Request to backport "fix memory leak when nghttp2 hd threshold is reached" into v14.x  #45295

Description

@ywave620

Version

14x

Platform

linux,mac,window

Subsystem

http2

What steps will reproduce the bug?

As shown in #35233
Fix in #41502

How often does it reproduce? Is there a required condition?

Consistent reproducable

What is the expected behavior?

no crash

What do you see instead?

./src/node_http2.cc:522:virtual node::http2::Http2Session::~Http2Session(): Assertion `(current_nghttp2_memory_) == (0)' failed.
1: 0xa02dd0 node::Abort() [node]

Additional information

I can't find the fix commit(f98a785) in https://github.com/nodejs/node/blob/v14.x/doc/changelogs/CHANGELOG_V14.md, since this is a critial bug that will lead to crash and v14.x is a LTS, I request Node team to backport it.

Activity

  1. aduh95 commented on Nov 3, 2022

    @aduh95
    Contributor

    v14.x is in maintenance mode, meaning no commit will land on it without a manual backport. Your best shot to see it being backported is to open a backport PR youself as documented in https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md.

  2. ywave620 commented on Nov 24, 2022

    @ywave620
    ContributorAuthor

    landed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions