Skip to content

Blob.stream().pipeTo() never resolves #48916

Closed
Closed
Blob.stream().pipeTo() never resolves#48916
Labels
confirmed-bugIssues and PRs for confirmed bugs.

Description

@alanshaw
alanshaw
opened on Jul 25, 2023

Version

20.5.0

Platform

Darwin Kernel Version 21.3.0: Wed Jan 5 21:37:58 PST 2022; root:xnu-8019.80.24~20/RELEASE_ARM64_T6000 arm64

Subsystem

No response

What steps will reproduce the bug?

async function main () {
  const blob = new Blob([
    new Uint8Array([
       58, 162, 101, 114, 111, 111, 116, 115, 129, 216,  42,
       88,  37,   0,   1,  85,  18,  32,  95, 102, 197,  19,
      218,  30, 103,  78, 133, 139,  57, 105,  28,  11,   0,
      246, 124, 167,  41, 140, 239, 220, 248, 168, 136,  35,
      196,  72, 236, 184, 232,  89, 103, 118, 101, 114, 115,
      105, 111, 110,   1
    ]),
    new Uint8Array([ 68 ]),
    new Uint8Array([
        1,  85,  18,  32,  95, 102, 197,  19,
      218,  30, 103,  78, 133, 139,  57, 105,
       28,  11,   0, 246, 124, 167,  41, 140,
      239, 220, 248, 168, 136,  35, 196,  72,
      236, 184, 232,  89
    ]),
    new Uint8Array([
       90, 189, 174, 145, 144, 134, 214,
      117,  47, 251, 231, 254,  29, 238,
        0,  29, 212, 201, 123, 107,  95,
      130,  24, 168, 207, 139, 134, 177,
      187,  88, 167,  36
    ])
  ])
  await blob.stream().pipeTo(new WritableStream({
    write (chunk) {
      console.log(chunk)
    }
  }))
}

main().then(() => console.log('done')).catch(console.error)

How often does it reproduce? Is there a required condition?

Every run.

What is the expected behavior? Why is that the expected behavior?

Expected to see all the chunks printed to console and then "done".

What do you see instead?

Uint8Array(59) [
   58, 162, 101, 114, 111, 111, 116, 115, 129, 216,  42,
   88,  37,   0,   1,  85,  18,  32,  95, 102, 197,  19,
  218,  30, 103,  78, 133, 139,  57, 105,  28,  11,   0,
  246, 124, 167,  41, 140, 239, 220, 248, 168, 136,  35,
  196,  72, 236, 184, 232,  89, 103, 118, 101, 114, 115,
  105, 111, 110,   1
]
Uint8Array(1) [ 68 ]

i.e. missing 2 chunks and no "done"

Additional information

No response

Activity

  1. bellbind commented on Jul 25, 2023

    @bellbind
    bellbind
    on Jul 25, 2023
    Contributor

    This code is OK on node-v20.3.1-darwin-arm64.tar.gz, and failed on node-v20.4.0-darwin-arm64.tar.gz

    other case:

    // blob.mjs
import {describe, it, before, after} from "node:test";
import {strict as assert} from "node:assert";

describe("blob", async () => {
  it("stream", async () => {
    const bufs = [];
    const blob = new Blob(["A", "B", "C"]);
    await blob.stream().pipeTo(new WritableStream({
      write(chunk) {
        bufs.push(new TextDecoder().decode(chunk));
      }
    }));
    assert.equal(bufs.join(""), "ABC");
    //assert.deepEqual(bufs, ["A", "B", "C"]); //node-20.3.1
    //assert.deepEqual(bufs, ["ABC"]); //chrome and firefox
  });
});
    $ asdf global nodejs 20.3.1
$ node blob.mjs
▶ blob
  ✔ stream (6.642917ms)
▶ blob (7.957ms)

ℹ tests 1
ℹ suites 1
ℹ pass 1
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 0.057125
    $ asdf global nodejs 20.4.0
$ node blob.mjs
▶ blob
  ✖ stream (6.048208ms)
    'Promise resolution is still pending but the event loop has already resolved'

▶ blob (6.810833ms)

ℹ tests 1
ℹ suites 1
ℹ pass 0
ℹ fail 0
ℹ cancelled 1
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 1.912083

✖ failing tests:

✖ stream (6.048208ms)
  'Promise resolution is still pending but the event loop has already resolved'

✖ blob (6.810833ms)
  'Promise resolution is still pending but the event loop has already resolved'

    I encountered the problem when using Blob with helia:

    import {describe, it} from "node:test";
import {strict as assert} from "node:assert";

import {createHelia} from "helia";
import {unixfs} from "@helia/unixfs";

describe("helia", async () => {
  it("unixfs.addByteStream", async () => {
    const node = await createHelia();
    const nodefs = unixfs(node);

    const blob = new Blob(["Hello World!"], {type: "text/plain"});
    const cid = await nodefs.addByteStream(blob.stream()); //never finished from nodejs>=20.4.0
    console.log(cid);

    await node.stop();
  });
});

    From the blame list of lib/internal/blob.js, the bug spawned by the change of 8cc1438 .

    This issue may be same as #48668

  2. bellbind
    added 2 commits that reference this issue on Jul 26, 2023

    fix lib/internal/blob.js for nodejs#48668 nodejs#48916

    e8dcf79

    lib: fix lib/internal/blob.js Blob.stream() for nodejs#48668 nodejs#4…

    b7d9941
  3. daeyeon
    added
    confirmed-bugIssues and PRs for confirmed bugs.
    on Jul 26, 2023
  4. debadree25
    added a commit that references this issue on Aug 12, 2023

    lib: fix to add resolve() before return at Blob.stream()'s source.pull()

    9f5022b
  5. debadree25
    closed this as completedin 3224527on Aug 12, 2023
  6. Ceres6
    added 2 commits that reference this issue on Aug 14, 2023

    lib: fix to add resolve() before return at Blob.stream()'s source.pull()

    c872bf2

    lib: fix to add resolve() before return at Blob.stream()'s source.pull()

    3ead299
  7. RafaelGSS
    added 2 commits that reference this issue on Aug 15, 2023

    lib: fix to add resolve() before return at Blob.stream()'s source.pull()

    14e2b2a

    lib: fix to add resolve() before return at Blob.stream()'s source.pull()

    8df3ba6
  8. RafaelGSS
    added 2 commits that reference this issue on Aug 16, 2023

    lib: fix to add resolve() before return at Blob.stream()'s source.pull()

    4d6880e

    lib: fix to add resolve() before return at Blob.stream()'s source.pull()

    dca8678
  9. vasco-santos
    added a commit that references this issue on Sep 6, 2023

    fix: revert workaround for bug in nodejs 20.5 (#905)

    a47ddd9
  10. panva
    added a commit that references this issue on Feb 18, 2024

    lib: fix to add resolve() before return at Blob.stream()'s source.pull()

    3224527
  11. tx-ravenxbsw3
    added a commit that references this issue on Sep 29, 2025

    fix: revert workaround for bug in nodejs 20.5 (#905)

    b15daf1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    confirmed-bugIssues and PRs for confirmed bugs.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions