Skip to content

Reflect.has triggers getters on global object contextified by vm #52737

Closed

Description

@lachrist

Version

v20.12.2

Platform

Darwin Laurents-MacBook-Air.local 23.2.0 Darwin Kernel Version 23.2.0: Wed Nov 15 21:59:33 PST 2023; root:xnu-10002.61.3~2/RELEASE_ARM64_T8112 arm64

Subsystem

vm

What steps will reproduce the bug?

import { createContext, runInContext } from "vm";
runInContext(
  `
    "use strict";
    Reflect.defineProperty(globalThis, "FOO", {
      get: () => {
        throw new Error("This should not get triggered");
      },
    });
    Reflect.has(globalThis, "FOO");
  `,
  createContext(),
);

How often does it reproduce? Is there a required condition?

All the time.

What is the expected behavior? Why is that the expected behavior?

Reflect.has should never trigger getter.

What do you see instead?

Reflect.has triggers getters for contextified global object. This is somehow similar to #52720 in that it makes contextified global objects break some invariants of the language.

In case anyone is wondering, I use vm to avoid having to spawn a new node process for each test cases of the test262 suite. These invariant breakages make some of them fail.

Maybe vm's contextified object are meant to be "magical" and I should stop reporting these issues. But then I feel this information would be a worthwhile addition to the doc.

Additional information

No response

Activity

  1. aduh95 commented on Apr 28, 2024

    @aduh95
    Contributor

    I'm not able to reproduce on the latest main. It looks like it's already been fixed, but the fix has not landed on 20.x.

  2. benjamingr commented on Apr 28, 2024

    @benjamingr
    Member

    Can confirm this repros on v20.12.2 but not on v22.0, I recall a fix (by @fhinkel ?) for something in that space a few months ago.

  3. lachrist commented on Apr 29, 2024

    @lachrist
    Author

    Same here, this issue does not show on my setup on 22.0.0. I wrongly assumed it would have because of #52720

  4. added
    vmIssues and PRs related to the vm subsystem.
    on Apr 29, 2024
  5. legendecas commented on Sep 3, 2024

    @legendecas
    Member

    The error is swallowed on v22.0.0 with d9c47e9. The getter is still getting invoked and side effects are observable.

    This was fixed in #53517 since v22.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    vmIssues and PRs related to the vm subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions