test-buffer-failed-alloc-typed-arrays test failures #53085

Activity

1. AdamMajer commented on May 21, 2024

   

   AdamMajer

   on May 21, 2024

   ContributorAuthor

   More actions

   It seems to be running out of memory ...

   > /usr/bin/time ./node22 test/parallel/test-buffer-failed-alloc-typed-arrays.js 
   (node:20905) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
   (Use `node22 --trace-deprecation ...` to show where the warning was created)
   3.30user 9.69system 0:12.93elapsed 100%CPU (0avgtext+0avgdata 19586856maxresident)k
   0inputs+0outputs (0major+6511685minor)pagefaults 0swaps
   
2. VoltrexKeyva

   added

   testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.

   on May 22, 2024
3. AdamMajer commented on May 22, 2024

   

   AdamMajer

   on May 22, 2024

   ContributorAuthor

   More actions

   This is a regression.

   With nodejs 21.7.2, the test uses only normally expected amount of memory,

   /usr/bin/time ./node21 test/parallel/test-buffer-failed-alloc-typed-arrays.js
   (node:15146) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
   (Use node21 --trace-deprecation ... to show where the warning was created)
   0.05user 0.01system 0:00.07elapsed 100%CPU (0avgtext+0avgdata 53176maxresident)k
   0inputs+0outputs (0major+3173minor)pagefaults 0swaps

   basically, 20G vs. 50M
4. targos commented on May 22, 2024

   

   targos

   on May 22, 2024

   Member

   More actions

   node/test/parallel/test-buffer-failed-alloc-typed-arrays.js

   Line 15 in 4a54a80

   const sizes = [1e10, 0, 0.1, -1, 'a', undefined, null, NaN];

   The test tries to allocate a buffer of size 1e10. This used to fail but is now possible after a V8 update.

   👍React with 👍1Reacted by Luigi Pinca
5. AdamMajer commented on May 22, 2024

   

   AdamMajer

   on May 22, 2024

   ContributorAuthor

   More actions

   Looks like changing this to 1e20 will fix this issue and keep the test around.

   👍React with 👍1Reacted by Luigi Pinca
6. AdamMajer

   added a commit that references this issue on May 22, 2024

   test: increase allocation so it fails for the test

   ...

   53450cd
7. nodejs-github-bot

   closed this as completedin #53099on May 24, 2024
8. nodejs-github-bot

   added a commit that references this issue on May 24, 2024

   test: increase allocation so it fails for the test

   ...

   501546e
9. targos

   added a commit that references this issue on Jun 1, 2024

   test: increase allocation so it fails for the test

   ...

   a371dea
10. soophoo

    added a commit that references this issue on Jun 20, 2024

    test: increase allocation so it fails for the test

    ...

    a1a5d71