Repository navigation
fs.readdir(path, { recursive: true }) is sync #56006
Description
Activity
We could mark it as legacy and decide to not fix the issue, as long as the promise version is correctly async we can probably get away with the callback version being wrongly sync.
We could mark it as legacy and decide to not fix the issue, as long as the promise version is correctly async we can probably get away with the callback version being wrongly sync.
If a sync version has a feature and its callback equivalent call doesn't... looks like a bad UX to me. Have we considered a new function instead? It seems more appropriate:
fs.recursiveReaddir()Nevermind, I have a PR almost ready to fix this.
- added a commit that references this issue
on Nov 27, 2024 - added a commit that references this issue
on Dec 5, 2024 - added a commit that references this issue
on Dec 6, 2024 - added a commit that references this issue
on Jan 5, 2025
Reviving #51749.
The implementation in #41439 is calling a synchronous approach even for an asynchronous call. See https://github.com/nodejs/node/blob/main/lib/fs.js#L1458.
I will take a quick look at that and see if I can fix it; otherwise, we might want to consider documenting it explicitly until we have a real solution for it.
cc: @Ethan-Arrowood